Skip to content

Commit

Permalink
fix: service account is not properly propagated from the execution in…
Browse files Browse the repository at this point in the history
…fo (#374)

* fix: service account is not properly propagated from the execution info

Signed-off-by: eugenejahn <[email protected]>
  • Loading branch information
eugenejahn authored Apr 13, 2022
1 parent 96a162d commit 2e250bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const ExecutionMetadataExtra: React.FC<{
launchPlan: launchPlanId,
maxParallelism,
rawOutputDataConfig,
authRole,
securityContext,
} = execution.spec;

const [launchPlanSpec, setLaunchPlanSpec] = React.useState<Partial<LaunchPlanSpec>>({});
Expand All @@ -50,11 +50,12 @@ export const ExecutionMetadataExtra: React.FC<{
const details: DetailItem[] = [
{
label: ExecutionMetadataLabels.iam,
value: authRole?.assumableIamRole || ExecutionMetadataLabels.securityContextDefault,
value: securityContext?.runAs?.iamRole || ExecutionMetadataLabels.securityContextDefault,
},
{
label: ExecutionMetadataLabels.serviceAccount,
value: authRole?.kubernetesServiceAccount || ExecutionMetadataLabels.securityContextDefault,
value:
securityContext?.runAs?.k8sServiceAccount || ExecutionMetadataLabels.securityContextDefault,
},
{
label: ExecutionMetadataLabels.rawOutputPrefix,
Expand Down
4 changes: 0 additions & 4 deletions src/models/Execution/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,6 @@ export const createWorkflowExecution = (
annotations,
};

if (authRole?.assumableIamRole || authRole?.kubernetesServiceAccount) {
spec.authRole = authRole;
}

if (securityContext?.runAs?.iamRole || securityContext?.runAs?.k8sServiceAccount) {
spec.securityContext = securityContext;
}
Expand Down

0 comments on commit 2e250bb

Please sign in to comment.