From 275b5e596ea4113003ae7507b5b79637605935cb Mon Sep 17 00:00:00 2001 From: samrabelachew Date: Sun, 3 Dec 2023 14:22:32 -0800 Subject: [PATCH] Revert "logging test (#720)" This reverts commit 8125a44b098e850df7868daeb76655fe9dee363a. --- server/neptune/temporalworker/server.go | 1 - server/neptune/workflows/internal/notifier/github.go | 8 -------- .../neptune/workflows/internal/pr/revision/processor.go | 2 -- server/neptune/workflows/internal/pr/revision/state.go | 1 - 4 files changed, 12 deletions(-) diff --git a/server/neptune/temporalworker/server.go b/server/neptune/temporalworker/server.go index 484435e49..a35c283e4 100644 --- a/server/neptune/temporalworker/server.go +++ b/server/neptune/temporalworker/server.go @@ -276,7 +276,6 @@ func (s Server) Start() error { Interceptors: []interceptor.WorkerInterceptor{ temporal.NewWorkerInterceptor(), }, - EnableLoggingInReplay: true, }) prWorker.RegisterActivity(s.GithubActivities) prWorker.RegisterActivity(s.TerraformActivities) diff --git a/server/neptune/workflows/internal/notifier/github.go b/server/neptune/workflows/internal/notifier/github.go index 1c851e025..45a7cd081 100644 --- a/server/neptune/workflows/internal/notifier/github.go +++ b/server/neptune/workflows/internal/notifier/github.go @@ -57,7 +57,6 @@ func (c *GithubCheckRunCache) CreateOrUpdate(ctx workflow.Context, deploymentID // if we haven't created one, let's do so now if !ok { - workflow.GetLogger(ctx).Info(fmt.Sprintf("cache before create: %v", c.deploymentCheckRunCache)) resp, err := c.load(ctx, deploymentID, request) if err != nil { return 0, err @@ -67,20 +66,17 @@ func (c *GithubCheckRunCache) CreateOrUpdate(ctx workflow.Context, deploymentID if resp.ID != 0 { c.deploymentCheckRunCache[key] = resp.ID c.deleteIfCompleted(resp.Status, key) - workflow.GetLogger(ctx).Info(fmt.Sprintf("cache after create: %v", c.deploymentCheckRunCache)) } return resp.ID, nil } // update existing checks - workflow.GetLogger(ctx).Info(fmt.Sprintf("cache before update: %v", c.deploymentCheckRunCache)) resp, err := c.update(ctx, deploymentID, request, checkRunID) if err != nil { return 0, err } c.deleteIfCompleted(resp.Status, key) - workflow.GetLogger(ctx).Info(fmt.Sprintf("cache after create: %v", c.deploymentCheckRunCache)) return checkRunID, nil } @@ -106,9 +102,7 @@ func (c *GithubCheckRunCache) update(ctx workflow.Context, externalID string, re } var resp activities.UpdateCheckRunResponse - workflow.GetLogger(ctx).Info(fmt.Sprintf("executing update check run activity: %s %s", request.Title, request.Sha)) err := workflow.ExecuteActivity(ctx, c.activities.GithubUpdateCheckRun, updateCheckRunRequest).Get(ctx, &resp) - workflow.GetLogger(ctx).Info(fmt.Sprintf("update check run activity complete: %s %s", request.Title, request.Sha)) if err != nil { return resp, errors.Wrapf(err, "updating check run with id: %d", checkRunID) } @@ -128,9 +122,7 @@ func (c *GithubCheckRunCache) load(ctx workflow.Context, externalID string, requ } var resp activities.CreateCheckRunResponse - workflow.GetLogger(ctx).Info(fmt.Sprintf("executing create check run activity: %s %s", request.Title, request.Sha)) err := workflow.ExecuteActivity(ctx, c.activities.GithubCreateCheckRun, createCheckRunRequest).Get(ctx, &resp) - workflow.GetLogger(ctx).Info(fmt.Sprintf("create check run activity complete: %s %s", request.Title, request.Sha)) if err != nil { return resp, errors.Wrap(err, "creating check run") } diff --git a/server/neptune/workflows/internal/pr/revision/processor.go b/server/neptune/workflows/internal/pr/revision/processor.go index 28529cb7b..d4b4f9e62 100644 --- a/server/neptune/workflows/internal/pr/revision/processor.go +++ b/server/neptune/workflows/internal/pr/revision/processor.go @@ -1,7 +1,6 @@ package revision import ( - "fmt" "github.com/google/uuid" metricNames "github.com/runatlantis/atlantis/server/metrics" internalContext "github.com/runatlantis/atlantis/server/neptune/context" @@ -148,7 +147,6 @@ func (p *Processor) awaitChildTerraformWorkflows(ctx workflow.Context, futures [ workflow.GetLogger(workflow.WithValue(ctx, internalContext.ErrKey, err)).Error("executing terraform workflow") return } - workflow.GetLogger(ctx).Info(fmt.Sprintf("child tf workflow ready: %s", resp.WorkflowState.ID)) results = append(results, resp) }) } diff --git a/server/neptune/workflows/internal/pr/revision/state.go b/server/neptune/workflows/internal/pr/revision/state.go index 844bbbc43..633d7f15a 100644 --- a/server/neptune/workflows/internal/pr/revision/state.go +++ b/server/neptune/workflows/internal/pr/revision/state.go @@ -46,7 +46,6 @@ func (s *StateReceiver) Notify(ctx workflow.Context, workflowState *state.Workfl workflow.GetLogger(ctx).Warn(fmt.Sprintf("skipping notifying root %s", workflowState.ID)) return } - workflow.GetLogger(ctx).Info(fmt.Sprintf("receiving state change signal: %s", rootInfo.Root.Name)) for _, notifier := range s.InternalNotifiers { if err := notifier.Notify(ctx, rootInfo.ToInternalInfo(), workflowState); err != nil {