-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URI cache to cache URIs across multiple files #348
Comments
The cache should work across files. At least that's the goal. So the same link should always only count as 1 in the total, no matter in how many files it occurs. |
Okay great, I'll try to extend the cache accordingly. |
PR up: #349 |
Current status: Caching across files is currently disabled. See test_caching_across_files. |
As tested here, the URI cache for caching URI check results across all input files, does not work as expected.
There is a test for repetition in a single file: https://github.com/lycheeverse/lychee/blob/master/lychee-bin/tests/cli.rs#L218-L229
But this worked before the new URI cache was implemented. This test may be extended to use two identical files.
@mre
Is it actually intended that two identical URLs in two separate files contribute only 1 to the total of the summary, or is it still 1 per input (and only the actual request skipped internally)? In the latter case, expanding or implementing the test would be more difficult.
The text was updated successfully, but these errors were encountered: