Report in JSON Format Still Includes Markdown Link

[aj-stein-nist]

Hello, already a big fan of this simple, elegant tool you wrote! I am working on using it to check our website content for a project. I noticed that, even when I pick format JSON, the file is inevitably a JSON file end with a Markdown link.

This is the result of the run from that action. I noticed prior to using GHA but here is an example.

https://github.com/aj-stein-nist/OSCAL/actions/runs/2301231596

html_link_report.zip

Is this intentional, can you/I/we consider generating the JSON without the additional non-JSON footer?

[aj-stein-nist]

Sigh, I put this in the wrong project, it was meant for the lychee-action repo. Would you like to move this or prefer I make another one? Apologies!

[mre]

Wow, apparently it checked 1400 links/second. Nice. 🤩
Moved the issue to lychee-action, no worries.

We have a check for that, but apparently it doesn't work:

lychee-action/entrypoint.sh

Lines 29 to 30 in c0d1093

	if [ "${INPUT_FORMAT}" == "markdown" ]; then
	echo "[Full Github Actions output](${GITHUB_WORKFLOW_URL})" >> "${INPUT_OUTPUT}"

Need to investigate a bit, but it's certainly a bug. Thanks for reporting.

[aj-stein-nist]

Awesome and timely, thanks @mre. Maybe this week I can try to fix the bug and contribute back. Sharing is caring afterall.

Thanks for the tool, big improvement over the alternatives. Looks like it is time to brush off my tabs to learn Rust and contribute back more than easier bash entrypoint fixes. 😅

[mre]

Actually can you try uses: lycheeverse/lychee-action@master? I think the latest version is just not released yet. If that works I'll release v1.4.2 with the fix.

[mre]

Version 1.5.0 with the fix was just released. ☺️