Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Replace the forked PTY code with upstream KDE/kpty #428

Closed
librehat opened this issue May 26, 2021 · 1 comment
Closed

Proposal: Replace the forked PTY code with upstream KDE/kpty #428

librehat opened this issue May 26, 2021 · 1 comment

Comments

@librehat
Copy link

Expected Behavior

This project was forked from the old Konsole code. These days, KDE Frameworks have been modularised and kpty is a maintained project with minimal dependencies (ECM and Qt) that could replace the old forked PTY code in this project.

Current Behavior

Old forked PTY/KPTY

Possible Solution

Replace the part of the current implementation with the upstream KDE/kpty library

Steps to Reproduce (for bugs)

N/A

Context

A possible solution to the lacking of Konsolewidget while lightening up the maintenance of this project

System Information

N/A

I'm willing to send in a PR but want to first see how everyone feels about this proposal

@yan12125
Copy link
Member

Thanks for bringing this up. Moving to KPty has been discussed some time ago in lxqt/qterminal#320, and there is a WIP branch in https://github.com/lxqt/qtermwidget/tree/kpty. However, there are different opinions in the aforementioned issue.

Closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants