Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Neovim's guicursor #128

Closed
yan12125 opened this issue May 7, 2017 · 9 comments
Closed

Support Neovim's guicursor #128

yan12125 opened this issue May 7, 2017 · 9 comments

Comments

@yan12125
Copy link
Member

yan12125 commented May 7, 2017

Neovim's guicursor option supports Konsole, while it's not working in QTerminal. As there are quite a few terminal-specific codes in Neovim, more investigation is necessary to know whether it's a QTermWidget bug or Neovim's.

Ref: neovim/neovim#3129

@DonnieWest
Copy link
Contributor

@yan12125 my understanding is that guicursor simply sends the appropriate escape code to the terminal to be handled for changing the cursor shape. #112 adds those escape codes and #111 allows a consumer of QTermWidget to be aware when the profile has changed and the cursor shape needs to be updated.

Here's a short example in python that should work with neovim however you might need to have guicursor set in your init.vim to properly use it as they describe here

@yan12125
Copy link
Member Author

yan12125 commented May 8, 2017

Thanks! That's what I'm looking for. However, as a term widget, my first idea is that it can handle cursor changes by itself. (Maybe an option to turn this feature on/off) Konsole's design is kind of strange...

@DarkDefender
Copy link

DarkDefender commented Jul 12, 2017

Can any of you guys help me out and see it everything works as expected with:
neovim/neovim#6997

Edit: Or if you have any comments and requests

@DonnieWest
Copy link
Contributor

@DarkDefender I'll try to check it out in the next few days. I noticed that my colors were broken on Neovim HEAD and was sad :P

@DarkDefender
Copy link

@DonnieWest Yes, that is an other problem I've been trying to fix:
neovim/neovim#7004

If you are talking about true color stuff that is.

@yan12125
Copy link
Member Author

Okay. I got DECSCUSR handling fixed in qtermwidget's handle-decscusr branch. I can confirm cursor shapes doesn't work in authentic neovim 0.2.0 on Arch Linux while it works with https://github.com/DarkDefender/neovim/tree/cursor_shape. The cursor is a block in the normal mode and an I-beam in the insert mode. Great work @DarkDefender!

@DarkDefender
Copy link

DarkDefender commented Jul 12, 2017

BTW do you guys know if this has any chance to make it into upstream konsole?
It would be really nice if neovim didn't have do to agressive checks for if the user is using konsole.

We currently check for KONSOLE_DBUS_SESSION and KONSOLE_PROFILE_NAME env variables to see if we have to output konsole specific codes to change cursor. However this doesn't work nicely with tmux for example (it changes cursor shape in all tmux windows). So it would be nice if konsole could eventually support decscusr also.

@yan12125
Copy link
Member Author

Dunno. If shouldn't be difficult but nobody works on it yet. I plan to backporting improvements in qtermwidget to konsole (lxqt/qterminal#320) but I haven't had so much time yet.

@DarkDefender
Copy link

Ah, I see. Thanks for explaining the situation for me. I wish you the best of luck in this matter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants