Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcuts going through panel #139

Open
the-loudspeaker opened this issue Sep 6, 2019 · 3 comments
Open

shortcuts going through panel #139

the-loudspeaker opened this issue Sep 6, 2019 · 3 comments

Comments

@the-loudspeaker
Copy link

I noticed that shortcuts like opening pcmanfm-qt etc directly go to the apps.
while shortcuts for opening applications menu goes like /panel/mainmenu/show_hide

The conflict I see is if someone removes the default panel and adds a new panel with say, only mainmenu and clock in it,
the shortcut set for mainmenu (super_L in case of lubuntu) doesn't work.
reason, it is set to /panel/mainmenu/show_hide
which refers to mainmenu on earlier panel.
In this case, user is likely to go to shortcuts editor(lxqt-config-globalkeyshortcuts) and check the settings. But only to find that the super_l key has show/hide main menu in description and set to /panel/mainmenu/show_hide
Note: He will see that this entry is in italics as compared to other entries(which are working, eg pcmanfm-qt)
Since user doesn't know about how things work, he/she is still gonna say that shortcut keys is broken.
But it is not, he needs to right click on application menu of new panel, select configure, and set shortcut to super_l which by default is set to alt+F1
Now after doing that, if one goes and checks the shortcut settings, one can see that there are two entries for Super_L :

  1. set to /panel/mainmenu/show_hide
  2. set to /panel/mainmenu2/show_hide
    Note: Earlier one is still in italics but both entries are in bold now.
Expected Behavior

Ideally a user expects if mainmenu is set to open via a particular key combination, it should work even if the mainmenu is present on panel other than default one. Coz he sees that he has set it in shortcut settings.

Current Behavior

Mainmenu is set to combination "x"
if mainmenu is removed and created again(on same/ different panel),
the earlier key combination "x" doesn't work

Note: same is observed for panel/desktopswitch , panel/taskbar/

Possible Solution

No idea yet. Still reading the cpp manual.
Instead if creating two entries as above, either the earlier entry should be modified coz it's obselete now. OR any key combination once set for particular function(opening menu/switching apps) should do that irrespective of panel's settings. (shortcuts shouldn't go through /panel)

Steps to Reproduce
  1. Set mainmenu to open on pressing super_l (do this using shortcuts editor)(another combination can also be used)
  2. check if it works.
  3. now remove the mainmenu from panel
  4. now add it again, on same place
  5. press the combination you set in step 1.
  6. Doesn't work
  7. go to shortcut settings and notice that the line for that shortcut which you set is in italics
  8. right click on the menu and select configure, see that it is set to alt+f1
  9. set it to same combinantion as in step 1.
  10. open shortcut settings again, see that there are two entries for the combination
    as mentioned above. Earlier one is still in italics but both entries are in bold now.
Context

seems like shortcuts are set according to panel and associated modules
while ideally they should be set according to "keys"
explaination:
looks like super key is set to launch /panel/mainmenu i.e it is set according to panel applet
but ideally panel applet should be set to open on pressing super key.

i.e instead of two entries in shortcut settings, the earlier entry should hav been modified to /panel/mainmenu2

System Information
  • Distribution & Version: Lubuntu 19.10 daily build
  • Kernel: 5.2.0-15-generic
  • Qt Version: 0.14.1
  • liblxqt Version: 0.14.1
  • Package version: 0.14.1
@the-loudspeaker
Copy link
Author

Same issue is also observed in debian with lxqt

@tsujan
Copy link
Member

tsujan commented Sep 6, 2019

There are 3 kinds of shortcuts: usual ones (commands, like pcmanfm-qt), dbus messages and shortcuts that are registered by apps like panel. As far as I've seen, only the 3rd kind may have this problem.

I agree that the user shouldn't need to know the differences and that all shortcuts should be treated in the same way. However, the current code can't do that. For example, registered shortcuts cannot be removed. Recently, a small progress has happened in git but it's far from complete.

@stefonarch
Copy link
Member

stefonarch commented Mar 14, 2022

Polishing my panel desktop switch shortcuts didn't work anymore, and so I learned too about those shortcuts in italic, I saw them but never really realised what this means, the list was just crapped with them.

An explanation and/or a button "remove defunct shortcuts" could be inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants