forked from dimagi/commcare-hq
-
Notifications
You must be signed in to change notification settings - Fork 4
Contributor Checklists
dannyroberts edited this page Feb 10, 2013
·
6 revisions
Before you submit a pull request, ask yourself the following questions:
- Before QA, are all your other submodules in a clean state, with all dependencies noted? Delete .pyc files (
find . -name '*.pyc' -delete
) to make sure you're running the code you think you're running. - Have you run the tests against your new code? (
python manage.py test
) Even though the build server does this too, it's best to catch before merging into master so you don't hold up the next deploy. - Have you manually tested the things that were likely to break, and compared the behavior to how it was before? Important, very low bar for testing: has a machine actually read and executed every line relevant to your changes?
- Did you remember to checkout the latest master on every submodule before committing? (You can run
git submodule foreach --recursive 'git checkout master; git pull'
to do so. Feel free to use the following script: https://gist.github.com/dannyroberts/4750437) - Did the build succeed?
- Did you preindex views?