Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ingress paths configurable #7

Closed
msvechla opened this issue May 30, 2017 · 2 comments
Closed

Make ingress paths configurable #7

msvechla opened this issue May 30, 2017 · 2 comments

Comments

@msvechla
Copy link

Hello,

I really like the great amount of configuration options with this chart.
Could you also add an option to change the ingress paths?

I want to be able to make an ingress like:
mysite.com/gitlab

Thank you!

@lwolf
Copy link
Owner

lwolf commented May 30, 2017

Hi, yes it makes sense since it is already configurable for gitlab itself using GITLAB_RELATIVE_URL_ROOT.

The next change should do it for you.

Index: gitlab/templates/ingress.yaml
<+>UTF-8
===================================================================
--- gitlab/templates/ingress.yaml	(revision f2fc7c9be7beed010b3fd224863067b1e72d12f5)
+++ gitlab/templates/ingress.yaml	(revision )
@@ -20,7 +20,7 @@
     - host: {{ . }}
       http:
         paths:
-          - path: /
+          - path: {{ default "/" .Values.config.GITLAB_RELATIVE_URL_ROOT }}
             backend:
               serviceName: {{ printf "%s-%s" $releaseName "gitlab" | trunc 63 }}
               servicePort: {{ $servicePort }}

@lwolf
Copy link
Owner

lwolf commented Jun 9, 2017

commited this to chart 0.2.5

@lwolf lwolf closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants