Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CEF 4606 (Chrome 94) #62

Open
rhaining opened this issue Oct 12, 2021 · 2 comments
Open

Update to CEF 4606 (Chrome 94) #62

rhaining opened this issue Oct 12, 2021 · 2 comments

Comments

@rhaining
Copy link

Hi,

If I use branch.txt to point to CEF 4606, I get a few compiler errors around Widevine/CDM, which seems to no longer be in the standard binaries of CEF, but which is behind a compiler flag. If I comment out the few respective functions which have errors, the project compiles fine and runs a-okay in my own project.

With Widevine seemingly no longer in the default binary of CEF, should CEF.swift update to no longer reference those? Or maybe plop the functions behind a preprocessor macro, in case someone wants to pull in their own CEF?

I'd be happy to push up a PR with the changes, if you'd like!

  • CEFCDMRegistrationError.g.swift:
    • the code in extension CEFCDMRegistrationError
  • CEFRegisterCDMCallback+Interop.g.swift:
    • everything
  • CEFRegisterCDMCallback+Interop.swift:
    • everything
  • CEFWebPluginUtils.swift:
    • registerWidevineCDM() and registerWidevineCDM

thanks!

-rob

@lvsti
Copy link
Owner

lvsti commented Oct 17, 2021

Hi, plz see: #61 (comment)

@lvsti
Copy link
Owner

lvsti commented Nov 2, 2021

I've made CEF 4606 and 4638 available, let me know if it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants