Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online font converter header issue with V9 #116

Closed
Superberti opened this issue Mar 20, 2024 · 4 comments · Fixed by #121
Closed

Online font converter header issue with V9 #116

Superberti opened this issue Mar 20, 2024 · 4 comments · Fixed by #121

Comments

@Superberti
Copy link

LVGL version

V9.0.0

What happened?

The online font converter tool has a small glitch when using it with V9. If you try to include the fonts in your project you may get an header include error. But it's easy to fix:

The header include macros from the converter tool

#ifdef LV_LVGL_H_INCLUDE_SIMPLE
    #include "lvgl.h"
#else
    #include "../../lvgl.h"
#endif

should be replaced with:

#ifdef __has_include
    #if __has_include("lvgl.h")
        #ifndef LV_LVGL_H_INCLUDE_SIMPLE
            #define LV_LVGL_H_INCLUDE_SIMPLE
        #endif
    #endif
#endif

#if defined(LV_LVGL_H_INCLUDE_SIMPLE)
    #include "lvgl.h"
#else
    #include "lvgl/lvgl.h"
#endif

How to reproduce?

No response

@kisvegabor
Copy link
Member

We are really using this structure on other places too. A pull request would be very welcome.

@lvgl-bot
Copy link

lvgl-bot commented Apr 5, 2024

We need some feedback on this issue.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

@kisvegabor kisvegabor transferred this issue from lvgl/lvgl Jun 20, 2024
@kisvegabor
Copy link
Member

Transferred to the font converter's repo.

@ev0rtex
Copy link
Contributor

ev0rtex commented Sep 5, 2024

I am just using this for the first time and ran into the same thing today... submitted a PR that fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants