Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title of the first pool is being displayed for all other pools of the model #455

Closed
jettero777 opened this issue Feb 14, 2020 · 4 comments · Fixed by #694
Closed

Title of the first pool is being displayed for all other pools of the model #455

jettero777 opened this issue Feb 14, 2020 · 4 comments · Fixed by #694
Labels

Comments

@jettero777
Copy link
Contributor

jettero777 commented Feb 14, 2020

What steps will reproduce the problem?

several ngRestPools in some model

What is the expected result?

title above list/single views should be same as currently selected pool

What do you get instead? (A Screenshot can help us a lot!)

title from first pool (first in menu) is being shown for all other pools too

Untitled-1

@nadar nadar self-assigned this Feb 16, 2020
@nadar
Copy link
Contributor

nadar commented Feb 16, 2020

Thanks, i need to take a closer look on this. But yes i can confirm this bug!

@nadar nadar added bug and removed bug:research labels Feb 16, 2020
@nadar
Copy link
Contributor

nadar commented Feb 16, 2020

And thanks for the report @jettero777! its very important for us.

@nadar nadar removed their assignment Apr 22, 2020
@hbugdoll
Copy link
Member

hbugdoll commented Nov 2, 2021

This bug is related to all admin menu items with same apiEndpoint, it's not restricted to NgRestPools.

e.g. title is "Foo" for all three following menu items:

return (new AdminMenuBuilder($this))
   ->node('My Module', '...')
   ->group('Group1')
      ->itemApi('Foo', '...', '...', 'api-mymodule-foo')
      ->itemPoolApi('Foo Pool1', '...', '...', 'api-mymodule-foo', 'poolid1')
   ->group('Group2')
      ->itemPoolApi('Foo Pool2', '...', '...', 'api-mymodule-foo', 'poolid2');

@hbugdoll
Copy link
Member

hbugdoll commented Nov 2, 2021

Second parameter in getApiDetail(apiEndpoint, pool) retrieving CRUD title in

'currentMenu' => Yii::$app->adminmenu->getApiDetail($this->getConfig()->getApiEndpoint()),
was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants