[feature](selectdb-cloud) Reduce meta-service log (apache#1067)

* Quote string in the tagged log * Add template to enable customized log for RPC requests
luwei16 · Nov 20, 2022 · 0a1b5fa · 0a1b5fa
1 parent 15c9d98
commit 0a1b5fa
Show file tree

Hide file tree

Showing 2 changed files with 103 additions and 83 deletions.
diff --git a/cloud/src/common/logging.h b/cloud/src/common/logging.h
@@ -4,6 +4,8 @@
 #include <fmt/format.h>
 #include <glog/logging.h>
 
+#include <type_traits>
+
 namespace selectdb {
 
 bool init_glog(const char* basename);
@@ -28,7 +30,12 @@ class TaggableLogger {
 
     template <typename V>
     TaggableLogger& tag(std::string_view key, const V& value) {
-        stream_ << '|' << key << '=' << value;
+        stream_ << ' ' << key << '=';
+        if constexpr (std::is_convertible_v<V, std::string_view>) {
+            stream_ << '"' << value << '"';
+        } else {
+            stream_ << value;
+        }
         return *this;
     }