Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing specs #2

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix failing specs #2

wants to merge 3 commits into from
+195 −79

Conversation

Novtopro
Copy link

@Novtopro Novtopro commented Nov 4, 2024

Fix #1

ronaldtse
ronaldtse requested changes Nov 4, 2024
View reviewed changes
lib/oasis/etm/colspec.rb
@@ -13,6 +13,7 @@ class Colspec < Lutaml::Model::Serializable

xml do
root "colspec"
namespace "-//OASIS//DTD XML Exchange Table Model 19990315//EN", "oasis"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This namespace is problematic.

  1. In newer versions of NISO JATS, they use:

https://github.com/ncbi/niso-jats/blob/master/publishing/1.1d3/Smallsamples/samplepub-oasis-and-xhtml1-mathml3.xml

xmlns:oasis="http://www.niso.org/standards/z39-96/ns/oasis-exchange/table"

  1. Also, in NISO STS, the namespace is:

xmlns:oasis (fixed value = http://www.niso.org/standards/z39-96/ns/oasis-exchange/table)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm thinking is that we provide a default namespace in the gem and at the same time we set a different namespace in niso-jats gem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that we should not include the fixture spec/fixtures/niso-jats/niso-jats-table-wrap.xml in this gem.

@Novtopro Novtopro marked this pull request as draft November 4, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix round-tripping specs
2 participants
@Novtopro @ronaldtse