Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUR-33] Refactor common behavior between Nova/Supernova in public_parameters caching #1086

Closed
huitseeker opened this issue Jan 30, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@huitseeker
Copy link
Contributor

huitseeker commented Jan 30, 2024

The logic for reading to/from cache in #1085 shows a lot of duplicated logic between supernova and nova. One of the issues of this definition is that the UX of the code isn't ideal, witness the uneven usage of logging and use of tap.

We want to relate two sets of three types:

  • lurk::proof::nova::PublicParams, nova_snark::PublicParams, nova_snark::FlatPublicParams,
  • lurk::proof::supernova::PublicParams, nova_snark::supernova::AuxParams, nova_snark::supernova::FlatAuxParams

and basically execute the same read-from-cache-and-extract or generate logic on each of those two pairs, returning a final type that's either a lurk::proof::nova::PublicParams or lurk::proof::supernova::PublicParams in the end. This seems to be a job for a trait with two associated types, which we could use to make the processing of this file more systematic.

LUR-33

@huitseeker huitseeker changed the title Refactor common behavior between Nova/Supernova in public_parameters caching [LUR-33] Refactor common behavior between Nova/Supernova in public_parameters caching Jan 30, 2024
@huitseeker huitseeker added the help wanted Extra attention is needed label Jan 30, 2024
@winston-h-zhang winston-h-zhang self-assigned this Jan 30, 2024
@huitseeker huitseeker closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants