Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preference page components #864

Closed
jbibla opened this issue Jun 20, 2018 · 2 comments · Fixed by #894
Closed

preference page components #864

jbibla opened this issue Jun 20, 2018 · 2 comments · Fixed by #894
Assignees
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@jbibla
Copy link
Collaborator

jbibla commented Jun 20, 2018

screen shot 2018-06-20 at 11 26 29 am

  1. excellent page!
  2. i don't think the "off" state needs to be red or "danger" - something like app-fg would be suitable
  3. the circle on the toggle (the part that you click) should have a border like our buttons
  4. the dropdowns should match the button styling or vice-versa (the borders are different)
  5. i think my preference would be for the in-button-icons to be on the right of the text
@faboweb faboweb added the design-work-needed 🎨 issues that require design work before development label Jun 26, 2018
@okwme
Copy link
Contributor

okwme commented Jun 26, 2018

check #888

@nylira nylira assigned jbibla and unassigned nylira Jun 26, 2018
@nylira
Copy link
Contributor

nylira commented Jun 27, 2018

@jolesbi Agree with 1, 2, 3, 4.

For number 4, the select buttons should use the same style as TmBtn.

Don't agree with 5. Icons to the left of text is a common convention (look at GitHub's buttons right now). There's already a prop in TmBtn that lets you move icons to the right side of the text, if we want specific icons on the right side (like -> arrows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants