Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to HTTPS-enabled LCD #1346

Closed
alessio opened this issue Sep 21, 2018 · 13 comments
Closed

Migrate to HTTPS-enabled LCD #1346

alessio opened this issue Sep 21, 2018 · 13 comments
Labels
high priority ❗ security 🛡️

Comments

@alessio
Copy link

alessio commented Sep 21, 2018

Since gaiacli 0.24.2-424-ge2da4caa the REST server now serves requests via HTTPS by default.
Please introduce HTTPS support.
@alessio alessio mentioned this issue Sep 21, 2018
Closed
@fedekunze
Copy link
Contributor

Thanks @alessio !

@faboweb faboweb mentioned this issue Sep 24, 2018
Closed
@faboweb faboweb added discuss blocked ✋ issues blocked by other implementations/issues and removed discuss labels Sep 25, 2018
@fedekunze fedekunze added discuss and removed discuss labels Sep 25, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 1, 2018

What's blocking this? Please include an explanation whenever you add the blocked label.

@faboweb
Copy link
Collaborator

faboweb commented Oct 2, 2018

We probably blocked this together in our team meeting last week. Feel free to add notes. ;) I assume this is blocked because we currently can't easily migrate to the latest develop of the SDK as we would loose compatibility with the testnet.
We may unblock this if we start using a staging branch.

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 2, 2018

OK, blocked because we're waiting for the new SDK release to incorporate this feature.

@faboweb
Copy link
Collaborator

faboweb commented Oct 16, 2018

Timeboxed 2 days

@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Oct 16, 2018
@faboweb
Copy link
Collaborator

faboweb commented Oct 17, 2018

Scope:

  • get https certificate data from console output when starting the lcd
  • pass https certificate data to view process
  • enable secure connection between view process and lcd (in lcdClient)

@faboweb faboweb assigned faboweb and unassigned fedekunze and faboweb Oct 30, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 31, 2018

Development blocked by #1507.

@NodeGuy NodeGuy added blocked ✋ issues blocked by other implementations/issues and removed blocked ✋ issues blocked by other implementations/issues labels Oct 31, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 2, 2018

Blocked by cosmos/cosmos-sdk#2664.

@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Nov 2, 2018
@NodeGuy NodeGuy mentioned this issue Nov 2, 2018
Closed
2 tasks
@faboweb
Copy link
Collaborator

faboweb commented Nov 5, 2018

@NodeGuy this apparently is fixed on latest.
You could use my branch for testing: #1515

@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Nov 5, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 5, 2018

Blocked until your branch is merged.

@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Nov 5, 2018
@faboweb
Copy link
Collaborator

faboweb commented Nov 8, 2018

My branch is dependent on your tests. ;)

@NodeGuy NodeGuy removed the blocked ✋ issues blocked by other implementations/issues label Nov 8, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 8, 2018

We decided to merge our PRs so this is no longer blocked.

@faboweb
Copy link
Collaborator

faboweb commented Nov 20, 2018

Done

@faboweb faboweb closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority ❗ security 🛡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Implement HTTPS support for Gaia Lite. luniehq/lunie
4 participants
@alessio @NodeGuy @faboweb @fedekunze