Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger support #1338

Closed
1 of 3 tasks
faboweb opened this issue Sep 20, 2018 · 7 comments · Fixed by #1814
Closed
1 of 3 tasks

Ledger support #1338

faboweb opened this issue Sep 20, 2018 · 7 comments · Fixed by #1814
Labels
epic high priority ❗ security 🛡️ split 🍌 issues that need to be split into several smaller issues with reduced scope

Comments

@faboweb
Copy link
Collaborator

faboweb commented Sep 20, 2018

Support for ledger nano.

  • Design user flow
  • Implement account creation
  • Implement signing
@faboweb faboweb added low priority has been discussed, will be addressed later security 🛡️ split 🍌 issues that need to be split into several smaller issues with reduced scope epic labels Sep 20, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Sep 21, 2018

Needs to be implemented in #1339

@NodeGuy
Copy link
Contributor

NodeGuy commented Nov 5, 2018

How about we close this because it's far off in the future?

@jbibla
Copy link
Collaborator

jbibla commented Nov 6, 2018

makes sense to me

@faboweb
Copy link
Collaborator Author

faboweb commented Nov 6, 2018

deal

@faboweb faboweb closed this as completed Nov 6, 2018
@fedekunze
Copy link
Contributor

Reopening as per discussion with @faboweb and @jleni and labeling high priority:

To Do:

  1. Copy the logic of unit test on voyager
  2. Add 2 cmds more here

@fedekunze fedekunze reopened this Nov 29, 2018
@fedekunze fedekunze added high priority ❗ and removed low priority has been discussed, will be addressed later labels Nov 29, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 29, 2018

Let's spike first if this works.

@jleni
Copy link
Contributor

jleni commented Nov 29, 2018

You can use the provided library (ledger-cosmos-js) as a reference. That has unit tests to show how to get app version, etc. It should work both on backend/frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic high priority ❗ security 🛡️ split 🍌 issues that need to be split into several smaller issues with reduced scope
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants