Use BitVector128 in CharacterMap<T> #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CharacterMap<T>
uses abool[] isOpeningCharacter
for quick lookup.This PR replaces that by a custom
BitVector128
that stores 128 bits is two ulong fields using a fixed size buffer.This results in a measurable speedup:
The benchmark:
The results on .NET Framework:
Before:
After:
The results on .NET Core:
Before:
After:
Conclusion: parsing time is reduced by about 3 %.