Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore backslashes in GFM AutoLinks #357

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Ignore backslashes in GFM AutoLinks #357

merged 1 commit into from
Jul 17, 2019

Conversation

MihaZupan
Copy link
Collaborator

@MihaZupan MihaZupan commented Jul 16, 2019

Fixes #356

The cause for the last character disappearing stems from this span calculation that uses link.Length even though backticks could be removed from the string.
This honors the difference between links and autolinks as stated in CommonMark and does not allow backtick escaping in automatic autolinks.

Edit: I meant backslash, not backtick

@xoofx xoofx merged commit 2595917 into xoofx:master Jul 17, 2019
@xoofx
Copy link
Owner

xoofx commented Jul 17, 2019

Thanks!

@MihaZupan MihaZupan changed the title Ignore backticks in GFM AutoLinks Ignore backslashes in GFM AutoLinks Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolink does not show the full text
2 participants