Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload needed when using read with color, width, height, (for settings) #4

Closed
reggi opened this issue Apr 26, 2023 · 2 comments
Closed

Comments

@reggi
Copy link

reggi commented Apr 26, 2023

I suggest adding an optional forth argument when these are in use for MagickReadSettings.

color, width, MagickReadSettings, callback
color, width, height, MagickReadSettings, callback

When width is provided without height just set height to the width for square 🤷

@reggi reggi changed the title Overload needed when using read with color, width, height Overload needed when using read with color, width, height, (for settings) Apr 26, 2023
@oscarotero
Copy link
Member

Hi.
Thanks but this repo only contains the same code as https://github.com/dlemstra/magick-wasm but with some modifications to make it work on Deno. So you should open the issue in the original repository.

@reggi
Copy link
Author

reggi commented Apr 26, 2023

@oscarotero yeah I had a feeling that was the case, sorry for opening all these up, feel free to close them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants