-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning, do not update to dev release 0.5.108 or greater if you don´t have the pinout on your desk #812
Comments
Hi, these do not get changed to 0, but it might be required to erase the settings store and re-import or re-set them. If you use a generic build, this is what happens: Lines 46 to 66 in 1d0860f
The compile defaults do not break legacy, so the pinout for CLK/MISO/MOSI are the same they have implicitly been for ESP8266 and ESP32 all the time. We might not be able to save everyone from re-doing some of the settings though as to accomodate the new SPI pins we had to modify the settings storage. |
To summarize: any user that upgrades to v108 or higher has to update their settings. ESP8266 users have to save and restart without actual changes, as they cannot configure MISO, MOSI, SCLK. Those Pins are fixed on ESP8266. However, the save and restart of ahoy is required once. (at least it was like that for me) ESP32 users need to keep CS, CE, IRQ as they always were and change MOSI, MISO and SCLK as follows:
Correct? |
as long as they do not have some exotic ESP32 board yes. (as ahoy could never change these pins that should hold for all users, only OpenDTU could do that until now). |
So far no one could have had an ESP32 board with Ahoy were SPI wasn't 19/23/18. So I don't expect that to be an issue. Maybe @rmayergfx can change the title of this issue, cause one doesn't need a specific pinout to resolve this, it's always the same. It just needs to be manually set once. |
let me make a quick PR that updates the docs as well. |
So when it is not changed why does a user need to setup this after update? why not set this to default settings instead of 0 after update? Would be great to have working defaults, also if the storage changes or not. |
because we have no way to tell. If there is a 0 in the flash at that position, that could well mean pin0. Only if we would see an erased cell at 255, that could prompt us to use the default. This si s developing project, and the non-configurability of SPI pins was a shortcoming coming from the 8266-only days. There can be instances where an update introduces slightly breaking changes. Also, this is a devlopment branch. You should be able to deal with something like this, or not use it. |
What about a hint in the GUI near the Settings to show the "default" Settings? Just to give a hint what GPIO should be there? |
The defaults only apply to standard ESP32 boards. This only happens to users that have a pre-existing config. Please test by making a full erase and flash it like a new device. |
Siehe #838 |
Ah, ich bin auch in die Falle getappt :( |
es steht in den release notes des commits, und auch im getting started. leider nicht in denen der release area. @lumapu kann man das ggf noch fixen? |
@markusdd ich hoffe so wie ich es jetzt eingetragen habe ist es korrekt |
Traumhaft! Danke dir. |
Dev. Fix 0.5.108
Will break your connection to your nrf24l01+ as the additional GPIO Settings will be set to default.
in my case with a board from Solarmodule-Gladbeck the nrf24l01+ is no longer available until you change
the default settings. My working settings was for this board is up to v0.5.107:
CS: GPIO5
CE: GPIO33
IRG: GPIO27
both LED off, but red one still is on.
Pin description from manufacturer for the circuit board:
MISO: 19
MOSI: 23
CLK: 18
IRQ: 27
EN: 33
CS: 5
@lumapu
Please change Default Settings MISO, MOSI, CLK not to 0!
The text was updated successfully, but these errors were encountered: