Extract resolution algorithm for imports

[SimenB]

From what I understand, the imports field has the same rules when it comes to conditions and wildcard substitutions that exports has. Do you have any plans to extract the algorithm used in this module so it can be reused for imports? Or create an resolve.imports module? 😀

[lukeed]

There are a couple additions to the imports side of things & I was planning on offering an extra module for it. I haven't actually done it yet, but it might make sense for there to be some facade module (eg resolve.exports/internal) to do the matching that both modules can reuse, depending on how much duplication there actually is.

There's also #6 to consider, which would mean that there'd have to be different error codes thrown. Still planned for a 2.0 release

[SimenB]

Awesome, looking forward to it! Very close to shipping exports in jest using this module and would love to use something similar for imports 👍

[chenyulun]

Create a package resolve.pkg

import { resolve, legacy } from 'resolve.pkg'
import { resolve, legacy, resolveExports, resolveImports } from 'resolve.pkg'
// type default 'exports'
resolve(pkgJSON, './foo', {type: 'exports'}) // === resolve(pkgJSON, './foo') === resolveExports(pkgJSON)
resolve(pkgJSON, '#dep', {type: 'imports'}) // === resolveImports(pkgJSON,  '#dep')

Add some necessary validation

That's my advice

[chenyulun]

Should not need the type argument, can be checked by # start，
With pkg-up, we can quickly find nearby package.json files

[okikio]

If y'all need a quick resolve.imports fork I created a gist with a tweaked version of resolve.exports but with support of the imports field, https://gist.github.com/okikio/3f07571c7707dc6e6eb4906b951c6bc3

[SimenB]

Jest 28 is out with exports support. Very happy with the integration! 😀 Is imports still on the roadmap @lukeed?

[thepassle]

If y'all need a quick resolve.imports fork I created a gist with a tweaked version of resolve.exports but with support of the imports field, https://gist.github.com/okikio/3f07571c7707dc6e6eb4906b951c6bc3

Is this published on npm anywhere by any chance? 🙂 Found myself needing to resolve imports, and was hoping this package already supported it

@lukeed would you be open for a contribution to support this usecase?

[okikio]

I could quickly publish it as a package if you'd like.

[thepassle]

That'd be awesome, thanks 🙂

[okikio]

@thepassle It's published as @okikio/resolve.imports

• https://www.npmjs.com/package/@okikio/resolve.imports

You can also use, it seems to be an alternative

• https://www.npmjs.com/package/resolve.imports

[thepassle]

@thepassle It's published as @okikio/resolve.imports

• https://www.npmjs.com/package/@okikio/resolve.imports

You can also use, it seems to be an alternative

• https://www.npmjs.com/package/resolve.imports

Thanks dude, appreciate it!

[SimenB]

Yeah, thanks! I just opened a PR in Jest using it 🙂

[SimenB]

As an aside, I opened up nodejs/node#44535 in node core asking then to expose the algorithm for others to use. Not much movement yet, but who knows 🙂

[unional]

FYI resolve.imports 1.2.4 is released.

[lukeed]

resolve.exports@next is released for early preview, which includes imports support. Total package is less than 1kB while still including the (treeshakable) legacy method 😅. I'll publish it as stable 2.0 Monday or Tuesday if all seems to work fine