Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling split() more than once results in 'undefined' text #47

Closed
danielkorte opened this issue Oct 28, 2022 · 3 comments · Fixed by #48
Closed

Calling split() more than once results in 'undefined' text #47

danielkorte opened this issue Oct 28, 2022 · 3 comments · Fixed by #48

Comments

@danielkorte
Copy link
Contributor

Using the responsive text example code and resizing the window multiple times and you’ll see the issue:
https://codepen.io/danielkorte/pen/OJEVRoN

The reason for the issue is split() calls revert() which calls SplitType.revert() which deletes the 'html' cached data so the second run of split() will again call revert() but 'html' will be undefined at that point.

@lukePeavey
Copy link
Owner

Yeah I see what you mean...

@lukePeavey
Copy link
Owner

@danielkorte Just released a patch for this. It should be fixed in 0.3.3. Thanks for reporting this!

Let me know if its working as expected in 0.3.3

@danielkorte
Copy link
Contributor Author

Looks good to me — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants