Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"uploadOnSave" doesn't work - FIXED #307

Open
dschiller opened this issue Feb 22, 2020 · 6 comments
Open

"uploadOnSave" doesn't work - FIXED #307

dschiller opened this issue Feb 22, 2020 · 6 comments

Comments

@dschiller
Copy link

If "uploadOnSave": false it still uploads on Saving. How to fix that ?

@dschiller
Copy link
Author

dschiller commented Feb 22, 2020

If somebody knows how to implement it, here is the Fix:

on-generate.js ( C:\Users\<User>\.vscode\extensions\lukasz-wronski.ftp-sync-0.3.9\modules )

module.exports = function(document, getFtpSync, skipOnSaveCheck) {
  if (document.uri.fsPath.indexOf(ftpconfig.rootPath().fsPath) < 0) return;

  var config = ftpconfig.getConfig();

  if (!config.uploadOnSave && !skipOnSaveCheck) return; // <------ THE FIX

@dschiller dschiller changed the title "uploadOnSave" doesn't work "uploadOnSave" doesn't work - FIXED Feb 22, 2020
@StephenBugden
Copy link

Hi,

I have the same problem, can't stop files uploading on save.

I tried adding the suggested line to on-generate.js but it didn't work for me.
Tried restarting vs code too,

Is there something else I need to do?

Steve

@dschiller
Copy link
Author

Try this one:

if (!config.uploadOnSave) return;

@StephenBugden
Copy link

Hi Dirk,

That works, thank you so much!

Steve

@dschiller
Copy link
Author

You are welcome Steve.

@NiklasVoigt
Copy link

Try this one:

if (!config.uploadOnSave) return;

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants