Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for updated $dimension and $duration types #98

Open
AndreBarr opened this issue Nov 4, 2024 · 2 comments
Open

Support for updated $dimension and $duration types #98

AndreBarr opened this issue Nov 4, 2024 · 2 comments

Comments

@AndreBarr
Copy link
Contributor

The $dimension and $duration types formats have been updated by this proposal:
design-tokens/community-group#244

Will this support be added?
I could possible contribute this update as well

@lukasoppermann
Copy link
Owner

Hey @AndreBarr,

YES, this should be supported.

And we probably need to adjust it in all transforms for composite tokens that use dimensions as well.

I would really appreciate a PR.

I think it is best to keep supporting the old behavior but return a console.error saying that using this format is deprecated and will be removed in one of the next major releses.

@lukasoppermann
Copy link
Owner

Hey @AndreBarr are you still up to create a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants