fix: report error on Sentinel connection refused (#445) #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
reviewed
Mar 31, 2017
lib/connectors/sentinel_connector.js
Outdated
| if (lastError) { | ||
| error += ' Last error: ' + lastError.message; | ||
| } | ||
| return callback(new Error(error)); |
There was a problem hiding this comment.
We shouldn't callback() with an error here when we still keep retrying since a callback must not be called more than once.
Instead, what about just emit an event (like "sentinelError") when all sentinels are unreachable just like when a connection to a standalone Redis server is down.
|
Added a callback to |
|
Just following up on this? Thoughts @luin ? |
|
Sorry for the delay. Merged and released with v3.0.0-1! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to report on a sentinel cluster not being able to connect.
This will also report retries in
redis.on('end', ...for subsequent retries of the Sentinel cluster, this behavior is similar to what happens on a failed connection with a single redis instance.This is the quickest fix I could think of.