Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster lazy connect #352

Merged
merged 5 commits into from
Jul 28, 2016
Merged

Cluster lazy connect #352

merged 5 commits into from
Jul 28, 2016

Conversation

shaharmor
Copy link
Collaborator

fixes #350
@luin not sure if i missed something

@luin
Copy link
Collaborator

luin commented Jul 22, 2016

Nice work! Cluster#disconnect() and Cluster#quit() require special handling since when not connected to the cluster, connectionPool will not emit drain event when calling reset([]).

@luin luin merged commit f1cadff into master Jul 28, 2016
@luin luin deleted the cluster-lazy-connect branch July 28, 2016 06:12
@shaharmor
Copy link
Collaborator Author

thnx @luin , didn't have any time for this

@snyk-bot snyk-bot mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luin luin

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add config option to not connect in the constructor
2 participants
@shaharmor @luin