fix(SENTINEL): disable active failover detection by default #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Ideally somebody would later tackle graceful shutdown by implementing ‘close’ command where quit is sent and failover detector is also closed |
AVVS
approved these changes
Jun 5, 2021
ioredis-robot
pushed a commit
that referenced
this pull request
Jun 5, 2021
## [4.27.5](v4.27.4...v4.27.5) (2021-06-05) ### Bug Fixes * **SENTINEL:** actively failover detection under an option ([#1363](#1363)) ([f02e383](f02e383))
|
🎉 This PR is included in version 4.27.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.5](redis/ioredis@v4.27.4...v4.27.5) (2021-06-05) ### Bug Fixes * **SENTINEL:** actively failover detection under an option ([#1363](redis/ioredis#1363)) ([f02e383](redis/ioredis@f02e383))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue related to connections used for active failover detection for sentinels not being cleaned up properly: #1362. Given that not many users realize the usefulness of this feature, and the feature does create more connections, we disable it by default and allow users to enable it with the option
failoverDetector.