Detect failover from +switch-master messages #1328
Merged
+525
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjomble
commented
Apr 8, 2021
| @@ -39,6 +41,7 @@ export interface ISentinelConnectionOptions extends ITcpConnectionOptions { | |||
| sentinelPassword?: string; | |||
| sentinels: Array<Partial<ISentinelAddress>>; | |||
| sentinelRetryStrategy?: (retryAttempts: number) => number | void | null; | |||
| sentinelReconnectStrategy?: (retryAttempts: number) => number | void | null; | |||
There was a problem hiding this comment.
Not sure about this name, could be confusing.
But I'm planning to submit a PR that documents all the sentinel options after this gets merged, so that might help.
mjomble
commented
Apr 8, 2021
luin
reviewed
Apr 18, 2021
|
I made the suggested changes and the code got much simpler 😄 |
luin
approved these changes
Apr 24, 2021
|
Thanks @mjomble! I just invited you as a collaborator so from now on you'll be able to approve and merge others' pull requests (which will automatically publish a new version). Feel free to participate anytime when you have time! |
ioredis-robot
pushed a commit
that referenced
this pull request
Apr 24, 2021
# [4.27.0](v4.26.0...v4.27.0) (2021-04-24) ### Features * **sentinel:** detect failover from +switch-master messages ([#1328](#1328)) ([a464151](a464151))
|
🎉 This PR is included in version 4.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
# [4.27.0](redis/ioredis@v4.26.0...v4.27.0) (2021-04-24) ### Features * **sentinel:** detect failover from +switch-master messages ([#1328](redis/ioredis#1328)) ([a464151](redis/ioredis@a464151))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
While working on this, I forgot about the
lastActiveSentinelsuggestion from the other issue. At this point, I'm not sure if it's needed, but I can still add it if it is.I've tested this with various failure scenarios in a Docker cluster and it successfully reconnected in all of them. I also simulated many of the scenarios in new test cases.