fix: revert parsing username via URI due to potential breaking changes

[luin]

Closes #1132.

Previously, users can specify the username in Redis connect URI unintentionally so parsing username leads potential breaking changes in this case. We still support username parameter so users can opt-in ACL explicitly.

[ioredis-robot]

🎉 This PR is included in version 4.17.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[billinghamj]

Could this be brought back with a flag to allow proper URI parsing? Or in a v5 release?

[luin]

@billinghamj I thought we can launch this in v5 but a flag sounds good to me.

[bpo]

@luin what do you think about just skipping the username assignment if the username is default?

    if (parsedAuth[0] && parsedAuth[0] != "default") {

I think that would preserve backward compatibility for older servers without requiring a flag or a major release.

[luin]

@bpo Actually people may put arbitrary usernames ex "user" for whatever reasons in the URL as they thought it doesn't matter and will be ignored by ioredis. So your approach works in most normal cases but still introduces risks of breaking their assumption.

It's debatable what kind of changes should be considered as breaking changes, but I think we should be cautious anyway so I'd prefer adding a flag or next major release.

[gkorland]

@luin do you still plan to put it back?

[luin]

@luin do you still plan to put it back?

Added back via #1284 😄