Handle connection after connect event was emitted #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for connect promise to resolve after the resolved connection has already been established, which means we miss the connect event. This can happen when Bluebird is set as the global Promise, and we connect to an ip address host for example. This fix checks to see if that's the case and invokes the connection handler directly. Thanks @luin for the recommendation. Fixes redis#977
|
I think we should ignore |
|
@luin You're right! Pushed a fix |
imatlopez
approved these changes
Apr 7, 2020
|
Thanks @alavers and @imatlopez for putting up a fix! Dealing with this bug right now and was hoping a fix would come out. Do you think we can get this merged and published soon? |
ioredis-robot
pushed a commit
that referenced
this pull request
Apr 11, 2020
|
🎉 This PR is included in version 4.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 15, 2020
This was referenced Apr 23, 2020
This was referenced May 4, 2020
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.16.2](redis/ioredis@v4.16.1...v4.16.2) (2020-04-11) ### Bug Fixes * dismiss security alerts for dev dependencies [skip release] ([758b3f2](redis/ioredis@758b3f2)) * handle connection after connect event was emitted ([#1095](redis/ioredis#1095)) ([16a0610](redis/ioredis@16a0610)), closes [#977](redis/ioredis#977)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for connect promise to resolve after the resolved
connection has already been established, which means we miss the connect
event. This can happen when Bluebird is set as the global Promise, and
we connect to an ip address host for example. This fix checks to see if
that's the case and invokes the connection handler directly. Thanks
@luin for the recommendation.
Fixes #977