fix: improve typing for redis.multi (#1580)

redis · May 17, 2022 · f9f875b · f9f875b
1 parent 7a9e5fd
commit f9f875b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/lib/transaction.ts b/lib/transaction.ts
@@ -5,11 +5,11 @@ import { Callback } from "./types";
 import { ChainableCommander } from "./utils/RedisCommander";
 
 export interface Transaction {
-  pipeline(commands?: [name: string, ...args: unknown[]][]): ChainableCommander;
+  pipeline(commands?: unknown[][]): ChainableCommander;
   multi(options: { pipeline: false }): Promise<"OK">;
   multi(): ChainableCommander;
   multi(options: { pipeline: true }): ChainableCommander;
-  multi(commands?: [name: string, ...args: unknown[]][]): ChainableCommander;
+  multi(commands?: unknown[][]): ChainableCommander;
 }
 
 export function addTransactionSupport(redis) {

diff --git a/test/typing/pipeline.test-d.ts b/test/typing/pipeline.test-d.ts
@@ -3,15 +3,24 @@ import Redis from "../../built";
 
 const redis = new Redis();
 
-expectType<Promise<[Error | null, unknown][] | null>>(
-  redis.pipeline().set("foo", "bar").get("foo").exec()
-);
+type RETURN_TYPE = Promise<[Error | null, unknown][] | null>;
+
+expectType<RETURN_TYPE>(redis.pipeline().set("foo", "bar").get("foo").exec());
 
-expectType<Promise<[Error | null, unknown][] | null>>(
+expectType<RETURN_TYPE>(
   redis
     .pipeline([
       ["set", "foo", "bar"],
       ["get", "foo"],
     ])
     .exec()
 );
+
+expectType<RETURN_TYPE>(
+  redis
+    .pipeline([
+      ["set", Buffer.from("foo"), "bar"],
+      ["incrby", "foo", 42],
+    ])
+    .exec()
+);