Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the ability to build ProvToolbox in a docker container to avoid having to install its dependencies locally.
make -f Makefile-docker build
will run the equivalent ofmvn package
andmake -f Makefile-docker extract
will extract theprovconvert
artefact.I've tried to make use of docker layer caching so that mvn dependencies are cached between builds (ie whilst you are making source changes). However, I've not been able to eliminate all the downloads.
I had to stop the
docker-service-translator
target from building since it, itself, uses docker. I tried usingmvn -pl -docker-service-translator ...
but this did not seem to work so I had to use the sed (sledgehammer) to removedocker-service-translator
frommodules-services/pom.xm
(cracked nut).Regards,
Danius