Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel testing #58

Open
bartblast opened this issue Aug 16, 2019 · 4 comments
Open

Parallel testing #58

bartblast opened this issue Aug 16, 2019 · 4 comments
Labels

Comments

@bartblast
Copy link

Is parallel testing supported (or planned) in LuckyFlow?

@jwoertink
Copy link
Member

Currently supported? no, but planned.... yes (I hope at least). I'd for sure like to add it in, but I'm waiting until the MT stuff in crystal is built-in and not just preview by flag.

@matthewmcgarvey
Copy link
Member

Because this library uses a single browser session it would not be possible to do parallel testing right now. I have no idea how they're planning on implementing parallel testing but we'd have to make it a session per thread or create a new session for every spec which would slow tests down by quite a bit (session essentially equals browser window)

@paulcsmith
Copy link
Member

I think this would be quite complex since we'd also need to change Avram to support different transactions per thread, and then use a session or something (as @matthewmcgarvey mentioned) to make sure Lucky is using the correct connection when rendering the page.

All this is possible, but is not simple 😂 So yeah this would be cool, but will likely be a ways out.

@jwoertink
Copy link
Member

Just tossing stuff out, but could we do something like where we open a single browser, then run flow specs in their own tabs? That would reduce overhead of opening and closing the browser, and it would allow sharing cookies and session if need be.

I do agree though, whatever the path for this, we're still quite a ways out from even beginning to tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants