You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LuckyFlow was meant to be like Capybara which can be used with any framework or library so it does not have a dependency on Lucky. The problem is that there are still helpful methods added that use classes provided by Lucky and Avram but because the dependency is missing we can't actually use or test those methods because they don't exist from LuckyFlow's point of view.
I believe that we should go ahead and make that dependency explicit so that we can fully exploit that connection and test it correctly.
Related #20
LuckyFlow was meant to be like Capybara which can be used with any framework or library so it does not have a dependency on Lucky. The problem is that there are still helpful methods added that use classes provided by Lucky and Avram but because the dependency is missing we can't actually use or test those methods because they don't exist from LuckyFlow's point of view.
I believe that we should go ahead and make that dependency explicit so that we can fully exploit that connection and test it correctly.
lucky_flow/src/lucky_flow.cr
Lines 27 to 40 in 9c4ca1d
lucky_flow/src/lucky_flow.cr
Lines 113 to 120 in 9c4ca1d
lucky_flow/src/lucky_flow/expectations.cr
Lines 17 to 23 in 9c4ca1d
The text was updated successfully, but these errors were encountered: