Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Crystal nightly #1025

Closed
jwoertink opened this issue Apr 20, 2024 · 3 comments · Fixed by #1051
Closed

Error with Crystal nightly #1025

jwoertink opened this issue Apr 20, 2024 · 3 comments · Fixed by #1051
Labels
bug Something isn't working

Comments

@jwoertink
Copy link
Member

This just recently popped up in the last few days.

image

Maybe related? luckyframework/lucky#1872

@jwoertink jwoertink added the bug Something isn't working label Apr 20, 2024
@jwoertink
Copy link
Member Author

More coming up now

image

@davidepaolotua
Copy link
Contributor

I kept getting errors in tests...

TL;DR: with the changes in the nightly build - optional/nillable settings in habitat are now forbidden

Just my two cents... most errors I've been seeing come directly from Habitat.
It seems that for whatever reason, when you check for raise_if_missing_settings, in the nightly build the check is way more stringent now. E.g:
Before, it was letting it pass if the setting was optional and you didn't provide it (aka: assuming it was there and nil)
Now, it fails. Aka: you have to always provide it - and setting it to null does not work (I didn't understand why though, but I didn't have the time to investigate it further)

What to do with that? Dunno :/ I doubt that even providing a default value would help in that case...

@jwoertink
Copy link
Member Author

Yeah, I figured something might be up with that. I was trying to test a patch in Crystal and couldn't even get that to run because I was getting weird errors.

I'll see if I can dig in more to find out. Will probably need to do a git bisect since v1.12.1 to see what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants