"Events" and "Commands" are no longer valid for Helper-JS

[JamieSinn]

javax.script.ScriptException: ReferenceError: "Commands" is not defined in nashorn:mozilla_compat.js at line number 67 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.throwAsScriptException(NashornScriptEngine.java:470) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:454) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:406) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:402) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:155) 2018-02-15 14:28:17 [WARN] at me.lucko.scriptcontroller.internal.ScriptImpl.run(ScriptImpl.java:162) 2018-02-15 14:28:17 [WARN] at me.lucko.scriptcontroller.internal.ScriptLoaderImpl.lambda$reload$1(ScriptLoaderImpl.java:294) 2018-02-15 14:28:17 [WARN] at me.lucko.helper.Scheduler$SchedulerWrappedRunnable.run(Scheduler.java:638) 2018-02-15 14:28:17 [WARN] at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:71) 2018-02-15 14:28:17 [WARN] at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:353) 2018-02-15 14:28:17 [WARN] at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:739) 2018-02-15 14:28:17 [WARN] at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) 2018-02-15 14:28:17 [WARN] at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) 2018-02-15 14:28:17 [WARN] at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) 2018-02-15 14:28:17 [WARN] at java.lang.Thread.run(Unknown Source) 2018-02-15 14:28:17 [WARN] Caused by: nashorn:mozilla_compat.js:67 ReferenceError: "Commands" is not defined 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1441) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.scripts.Script$Recompilation$9$1362A$\=nashorn\!mozilla_compat.value-1#__noSuchProperty__(nashorn:mozilla_compat.js:67) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.scripts.Script$17$gui.:program(plugins/helper-js/scripts/bin/lobby/gui.js:39) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:637) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.Context.evaluateSource(Context.java:1222) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.Context.load(Context.java:839) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.objects.Global.load(Global.java:1545) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.scripts.Script$16$\^eval\_.:program(<eval>:1) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:637) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393) 2018-02-15 14:28:17 [WARN] at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:449) 2018-02-15 14:28:17 [WARN] ... 13 more

[lucko]

Yeah, latest update needs work - just switch back to the older version.

[JamieSinn]

Tag me when you've got a working build.

[andrewkm]

@lucko any news on this? Ready to test here :)

[lucko]

Sorry, I'm super busy atm.
Feel free to have a play around with it yourself, will happily accept a PR which fixes things. :)

If not, hopefully I'll get a chance to look sometime this week.

[lucko]

Fixed in 510b9bb

[JamieSinn]

Seems like there have been some API changes at least.
https://pastebin.com/raw/zpEF5Jir

[lucko]

Yes, the version was bumped to 5.0.0 to reflect that.