Use Bazelisk and update to Bazel 7.4.0 #61
Conversation
| @@ -1,3 +1 @@ | |||
| common --config=rules | |||
There was a problem hiding this comment.
Do you know why this existed to begin with?
Why have a rules section when we could just put those options under the commands themselves? E.g. instead of build:rules --disk_cache=.bazel_cache, we could do build --disk_cache=.bazel_cache.
There was a problem hiding this comment.
These configs existed because way back when Bazel was new the tests and rules had separate config.
Also because of us wanting to have a single place for the disk cache, which I realize I broke by removing this. I'll deal with that.
.bazelrc_shared
Outdated
| @@ -22,14 +22,3 @@ test --test_output=all | |||
|
|
|||
| build:rules --disk_cache=.bazel_cache | |||
There was a problem hiding this comment.
Will this option still take effect, now that we've removed the common --config=rules line?
| @@ -1,3 +1 @@ | |||
| common --config=rules | |||
| common:v7.2 --config=rules_v7.2 | |||
There was a problem hiding this comment.
Do you know why this existed too?
Why not do foo:v7.2 bar instead of foo:rules_v7.2 bar?
| @@ -22,14 +22,3 @@ test --test_output=all | |||
|
|
|||
| build:rules --disk_cache=.bazel_cache | |||
| build:tests --disk_cache=../.bazel_cache | |||
|
|
|||
| common:rules_v7.2 --config=noop | |||
There was a problem hiding this comment.
Do you know what this deleted portion was doing?
There was a problem hiding this comment.
The per version config existed so we could set flags for certain versions of Bazel and not others. Back before 1.0 things would change often enough that we'd often need a different set of flags for each version.
Now that we're really only supporting 1 version of Bazel (because we only use these rules internally) we haven't had to do that for a while.
The noop config was a way to have a version config that did nothing. The version configs were automatically generated by the old tools/bazel, so you had to have them point to something, even if they did nothing.
tests/.bazelrc
Outdated
| @@ -1,5 +1,3 @@ | |||
| common --config=tests | |||
There was a problem hiding this comment.
.bazelrc_shared still contains this line:
build:tests --disk_cache=../.bazel_cache
If delete common --config=tests, won't that option no longer take effect?
There was a problem hiding this comment.
Yep. I missed that and will deal with this.
No description provided.