Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Requests from Feather] handshake #608

Closed
karsa-mistmere opened this issue Apr 22, 2022 · 7 comments · Fixed by #1835
Closed

[Icon Requests from Feather] handshake #608

karsa-mistmere opened this issue Apr 22, 2022 · 7 comments · Fixed by #1835

Comments

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Apr 22, 2022

As per #119 and feathericons/feather#444 and feathericons/feather#486:

image
handshake

@ericfennis
Copy link
Member

Nice, Can image this is really hard one to design.
But I think the sleeves are missing to recognise the handshake.

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Apr 24, 2022

I just don't think there's enough place to fit in sleeves. We could add an extra line at the wrists, but I'm not sure if it's super helpful:
image
handshake
handshake

@lvauvillier
Copy link

@karsa-mistmere nice work! Are those icons available in your repo? Or can you share the svg while waiting them to be officially supported?
Thanks a lot!

@jguddas
Copy link
Member

jguddas commented May 19, 2023

Can we get something that is in the style of the other hand icons, maybe using negative space Frame 2 (1)?

@TheMikeyRoss
Copy link

I just don't think there's enough place to fit in sleeves. We could add an extra line at the wrists, but I'm not sure if it's super helpful: image handshake handshake

These look nice, we can have 2 version a horizontal and a diagonal

@github-actions github-actions bot added the Stale label Jan 26, 2024
@karsa-mistmere
Copy link
Member Author

Here are two newly designed, slightly more geometrical and larger variants that I think are both definite improvements upon my earlier designs:
image

image

@ericfennis
Copy link
Member

@karsa-mistmere Nice designs are better than the first iteration, I like the first one the most.
I understand why you designed the angled one, it uses a bit more space efficiently. But since handshakes are often done horizontally, I'm unsure if this variant is that recognizable as a handshake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants