Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 19 support #2134

Closed
2 of 14 tasks
wojtekmaj opened this issue May 6, 2024 · 6 comments · Fixed by #2254
Closed
2 of 14 tasks

React 19 support #2134

wojtekmaj opened this issue May 6, 2024 · 6 comments · Fixed by #2254
Labels
💡 idea New ideas

Comments

@wojtekmaj
Copy link
Contributor

Package

  • lucide
  • lucide-angular
  • lucide-flutter
  • lucide-preact
  • lucide-react
  • lucide-react-native
  • lucide-solid
  • lucide-svelte
  • lucide-vue
  • lucide-vue-next
  • Figma plugin
  • all JS packages
  • site

Description

We should test the package in React 19 beta and, if it succeeds, accept React 19.0.0 as a peerDependency.

Use cases

I think it requires no further explanation :)

Checklist

  • I have searched the existing issues to make sure this bug has not already been reported.
@wojtekmaj wojtekmaj added the 💡 idea New ideas label May 6, 2024
@oasaleh
Copy link

oasaleh commented May 10, 2024

Is there a workaround for now?

@Oksitaine
Copy link

I have the same issue, someone get new about it ?

@wojtekmaj
Copy link
Contributor Author

I tested the package with React 19 RC and found no issues. I think we're safe to update peerDeps.

@Gamez0
Copy link

Gamez0 commented Jun 20, 2024

When will support for React 19 be available?
If it's just a matter of adding ^19.0.0 to peerDependencies in the lucide-react/package.json, can I submit a PR for that?

@ericfennis
Copy link
Member

@wojtekmaj Awesome tnx for checking

@ericfennis ericfennis mentioned this issue Jun 25, 2024
Merged
5 tasks
@Gamez0 Gamez0 mentioned this issue Jun 27, 2024
Open
2 tasks
@broken99records
Copy link

any update on this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 idea New ideas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lucide-react): Add support for React 19 lucide-icons/lucide
6 participants
@wojtekmaj @ericfennis @Gamez0 @broken99records @oasaleh @Oksitaine