Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply, Reply All, and Forward #128

Closed
Andreto opened this issue Nov 6, 2020 · 15 comments · Fixed by #341
Closed

Reply, Reply All, and Forward #128

Andreto opened this issue Nov 6, 2020 · 15 comments · Fixed by #341
Labels
🎨 icon About new icons

Comments

@Andreto
Copy link
Member

Andreto commented Nov 6, 2020

What design direction should we go in for Reply, Reply All, and Forward?
In the request issues on Feather, two example designs were given, similar to the icons in Outlook and Gmail.

Requests from feather:
Reply: feathericons/feather#380
Replay All: feathericons/feather#381
Forward: feathericons/feather#384

Outlook (simple lines):
image
Gmail (filled shapes):
image

I prefer the Gmail approach a bit more and I made icons for reply and reply all:
image
image

@ericfennis
Copy link
Member

I think I like it more like this way:
Reply & reply-all : https://github.com/feathericons/feather/pull/574/files
Forward : feathericons/feather#578

It matches way better with the rest of the arrow icons

@ericfennis ericfennis added the 🎨 icon About new icons label Nov 7, 2020
@Andreto
Copy link
Member Author

Andreto commented Nov 7, 2020

I'm a bit skeptical about having the same icon for both reply and forward but in different directions. To me, it doesn't feel totally given that left should be reply and right should be forward. We already have normal arrows tough so maybe it's up to users to decide which icons to use.

@ericfennis
Copy link
Member

Yeah true, I'm curious what other people think about it.

@ghost
Copy link

ghost commented Nov 11, 2020

I personally prefer the one-line icon. Also for the forward, the simple arrow (right or left whatever) works fine IMO (just like Outlook and Gmail).

@ericfennis
Copy link
Member

I agree with @delnyn, looking at gmail for example it. Here a screenshot. Screenshot_20201111-125900.jpg

@ericfennis
Copy link
Member

ericfennis commented Nov 13, 2020

@Andreto I think we can with both ideas. So designers can choose which one they want to implement.
I think we can rename it to arrow-big-corner-left, arrow-big-corner-left-double. So we can create more big arrows as well.

@Andreto
Copy link
Member Author

Andreto commented Nov 14, 2020


arrow-big-corner-left image

arrow-big-corner-left-double image / image

arrow-big-right image

@ericfennis
Copy link
Member

@Andreto Nice I like them, make sure the double arrow has 2px spacing between the lines.

@Andreto
Copy link
Member Author

Andreto commented Dec 4, 2020

@ericfennis Sorry for being a bit inactive lately, I've had a lot to do in school.
Two questions regarding the thin forward and reply icons.

1. How long should the line on the right be. I prefer the ones where it sticks out a bit. Looks more balanced in my opinion.
image

image

2. What should they be named. If I'm not mistaken, naming it as what the icon represents was preferred over function.

@ghost
Copy link

ghost commented Dec 4, 2020

IMO the middle one is the best

@ericfennis
Copy link
Member

@Andreto No problem, your education is always more important!

I'm like number one en number two. For the name, hmm, arrow-corner-up-left or arrow-bend-up-left?
But arrow-corner-up-leftis maybe too close to the corner-** icons. There is also an option maybe to replace the current corner-** but I'm not sure what the rest of the community will think about that idea.

@mittalyashu
Copy link
Member

How about without joining this part?

CleanShot 2021-01-14 at 10 06 53@2x

@Andreto
Copy link
Member Author

Andreto commented Jan 22, 2021

@mittalyashu How do you mean? Like this?
image

@mittalyashu
Copy link
Member

@Andreto Quite similar but the gap seems to be bit uneven.

An even spacing might look good for example:

CleanShot 2021-01-22 at 23 26 49@2x

CleanShot 2021-01-22 at 23 26 32@2x

You can ignore my suggestion for adding the gap too, since exceptions are allowed 😉.

@ericfennis
Copy link
Member

ericfennis commented Jun 19, 2021

Closed by #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants