Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2018-0006: Uncontrolled recursion leads to abort in deserialization #11

Open
github-actions bot opened this issue Oct 27, 2019 · 1 comment
Assignees
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed security About security concerns

Comments

@github-actions
Copy link

Uncontrolled recursion leads to abort in deserialization

Details
Package yaml-rust
Version 0.3.5
URL chyh1990/yaml-rust#109
Date 2018-09-17
Patched versions >= 0.4.1

Affected versions of this crate did not prevent deep recursion while
deserializing data structures.

This allows an attacker to make a YAML file with deeply nested structures
that causes an abort while deserializing it.

The flaw was corrected by checking the recursion depth.

See advisory page for additional details.

@imclint21 imclint21 self-assigned this Oct 27, 2019
@imclint21 imclint21 added help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Oct 28, 2019
@imclint21 imclint21 added this to the pre-alpha milestone Nov 3, 2019
@imclint21 imclint21 modified the milestones: pre-alpha, alpha Jan 2, 2020
@imclint21 imclint21 added the security About security concerns label Feb 1, 2020
@shuni64
Copy link
Contributor

shuni64 commented Feb 1, 2020

This doesn't really affect us. The only yaml file read by clap is embedded in the binary, so unless the attacker modifies it there's no way that this bug can be triggered.

Regardless of the low impact of this bug, this issue can be left open until we update clap to version 3 (not released yet), which doesn't have the problem anymore.

@imclint21 imclint21 removed this from the alpha milestone Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed security About security concerns
Projects
None yet
Development

No branches or pull requests

2 participants