Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for specifiying sheet height as an absolute value #37

Closed
anqus opened this issue Dec 26, 2021 · 1 comment · Fixed by #38
Closed

Option for specifiying sheet height as an absolute value #37

anqus opened this issue Dec 26, 2021 · 1 comment · Fixed by #38
Labels
enhancement New feature or request Thank You ❤️ For people who appreciate my work

Comments

@anqus
Copy link

anqus commented Dec 26, 2021

Hello,

First of all thanks for the great package, it's awesome!

I have made a few small changes on a local branch, and was hoping to PR them in to main, as I think others may find them useful.

The changes allow you to specify the sheet height as an absolute value rather than a percentage, which can be flagged in the sheet options.

Basically this means that if you specify the sheet position as 200 point, it will show as 200 point across all devices, and device orientations. Useful if the contents are fixed, and require the same height in all situations.

Happy to create a quick PR and merge in if you think it'd come in handy!

Cheers.
lucaszischka added a commit that referenced this issue Dec 27, 2021
@lucaszischka
First Steps
bf58f37 
- Update Copyright
- Add `.absolutePositionValue` option (fixes #37)
- Add `BottomSheetPositionAbsolute`
- Refactor value calculation
- Update to IOS 15 (endEditing, animation, @available(iOSApplicationExtension, unavailable))
@lucaszischka lucaszischka mentioned this issue Dec 27, 2021
Merged
@lucaszischka lucaszischka added enhancement New feature or request Thank You ❤️ For people who appreciate my work labels Dec 27, 2021
@lucaszischka
Copy link
Owner

Thank you for your idea and the kind words. It is already in the #38 PullRequest or the #new-year-update branch. If you want, you can test it and tell me it works as expected.

lucaszischka added a commit that referenced this issue Dec 28, 2021
@lucaszischka
New Year Update (#38)
1702332 
- Update Copyright
- Update swift-tools-version
- Update deprecated code (real fix for #19, replaces #20)
- Add `.absolutePositionValue` option (closes #37)
- Add `BottomSheetPositionAbsolute`
- Use explicit animations (fixes #31)
- Hide examples in ReadMe
- Implement and fix `.appleScrollBehavior` (closes #37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Thank You ❤️ For people who appreciate my work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Year Update lucaszischka/BottomSheet
2 participants
@anqus @lucaszischka