Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executor does not update root lock if project is in dependency group #194

Closed
kylebjordahl opened this issue Mar 27, 2024 · 2 comments · Fixed by #195
Closed

Add executor does not update root lock if project is in dependency group #194

kylebjordahl opened this issue Mar 27, 2024 · 2 comments · Fixed by #195
Labels
bug Something isn't working released

Comments

@kylebjordahl
Copy link
Contributor

Current Behavior

If a project is listed in the root pyproject.toml as part of a dependency group (not in the rootPyprojectToml.tool.poetry.dependencies collection) then updateDependencyTree fails to detect that the root pyproject requires re-locking when running the add target

Expected Behavior

Running the add target for any python project depended on in the root pyproject causes that pyproject to be relocked.

Steps to Reproduce

  1. Create new shared venv workspace
  2. add new python project with a root dependency group (anything other than blank)
  3. add a non-local dependency to the app
  4. see that root poetry.lock does not contain the added non-local dependency

Nx Report

Node   : 20.11.1
OS     : darwin-arm64
npm    : 10.2.4

nx             : 18.1.2
@nx/js         : 18.1.2
@nx/workspace  : 18.1.2
@nx/devkit     : 18.1.2
@nrwl/tao      : 18.1.2
typescript     : 5.4.3
---------------------------------------
Community plugins:
@nxlv/python : 18.0.0

Failure Logs

No response

Additional Information

I have a fix, PR coming shortly

@kylebjordahl kylebjordahl added bug Something isn't working needs-triage This issue needs triage labels Mar 27, 2024
@kylebjordahl
Copy link
Contributor Author

kylebjordahl commented Mar 27, 2024

FYI - While working on the PR for this, I discovered that mock-fs is broken for Node 20

Copy link

🎉 This issue has been resolved in version 18.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants