Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only apply server's transport parameters after handshake completion #3085

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

marten-seemann
Copy link
Member

On the client side, 0-RTT packets have to be sent using the old transport parameters. We're only allowed to use the updated values for 1-RTT packets.

See https://tools.ietf.org/html/draft-ietf-quic-transport-34#section-7.4.1.

On the client side, 0-RTT packets have to be sent using the old
transport parameters. We're only allowed to use the updated values for
1-RTT packets.
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #3085 (d970a10) into master (9dcb56b) will increase coverage by 0.10%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3085      +/-   ##
==========================================
+ Coverage   86.03%   86.13%   +0.10%     
==========================================
  Files         132      132              
  Lines        9441     9446       +5     
==========================================
+ Hits         8122     8136      +14     
+ Misses        957      949       -8     
+ Partials      362      361       -1     
Impacted Files Coverage Δ
session.go 77.61% <89.47%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcb56b...d970a10. Read the comment docs.

@marten-seemann marten-seemann merged commit 1d2756f into master Mar 16, 2021
@marten-seemann marten-seemann deleted the client-hold-tp-until-handshake-completion branch March 16, 2021 15:13
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants