make sure the server is stopped before closing all server sessions #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3020 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 135 135
Lines 9457 9458 +1
=======================================
+ Hits 8146 8147 +1
Misses 952 952
Partials 359 359
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jan 23, 2021
server.go
Outdated
Comment on lines
292
to
297
| s.sessionHandler.CloseServer() | ||
| var err error | ||
| if createdPacketConn { | ||
| err = s.sessionHandler.Destroy() | ||
| } | ||
| <-s.running |
There was a problem hiding this comment.
I think CloseServer() could still be called before (*baseServer).run finishes processing a packet and calls AddWithConnID with the same end result.
I think receiving <-s.running is necessary before calling CloseServer() to ensure that (*baseServer).run is not processing a packet.
<-s.running
s.sessionHandler.CloseServer()
var err error
if createdPacketConn {
err = s.sessionHandler.Destroy()
}There was a problem hiding this comment.
Right. Thank you!
marten-seemann
force-pushed
the
fix-server-closing
branch
from
5f76dbd
to
aea8f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3019.
@rip-create-your-account Do you think this fixes the bug that you discovered?