improve the warning about the UDP receive buffer size #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marten-seemann
commented
Dec 2, 2020
marten-seemann
commented
- only print it once
- link to the wiki page: https://github.com/lucas-clemente/quic-go/wiki/UDP-Receive-Buffer-Size
Codecov Report
@@ Coverage Diff @@
## master #2923 +/- ##
==========================================
+ Coverage 85.77% 85.79% +0.02%
==========================================
Files 133 133
Lines 9180 9178 -2
==========================================
Hits 7874 7874
+ Misses 958 956 -2
Partials 348 348
Continue to review full report at Codecov.
|
mvdan
approved these changes
Dec 3, 2020
packet_handler_map.go
Outdated
| setReceiveBuffer(c, logger) | ||
| if err := setReceiveBuffer(c, logger); err != nil { | ||
| receiveBufferWarningOnce.Do(func() { | ||
| log.Printf("%s. See https://github.com/lucas-clemente/quic-go/wiki/UDP-Receive-Buffer-Size for details.\n", err) |
There was a problem hiding this comment.
nit: logs already end in newlines, so you don't need the trailing newline
packet_handler_map_test.go
Outdated
| @@ -63,6 +66,7 @@ var _ = Describe("Packet Handler Map", func() { | |||
| }) | |||
|
|
|||
| JustBeforeEach(func() { | |||
| log.SetOutput(ioutil.Discard) | |||
There was a problem hiding this comment.
This is not thread-safe, so I would honestly do it at the start of TestMain and not worry about setting it back to anything else. I assume none of the tests should log directly to stderr, anyway.
marten-seemann
force-pushed
the
receive-buffer-warning
branch
from
e3e663d
to
b0974c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.