Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deadlock when closing the server and the connection at the same time #2849

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2716.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #2849 into master will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2849      +/-   ##
==========================================
- Coverage   85.83%   85.81%   -0.03%     
==========================================
  Files         134      134              
  Lines        9036     9039       +3     
==========================================
  Hits         7756     7756              
- Misses        939      941       +2     
- Partials      341      342       +1     
Impacted Files Coverage Δ
packet_handler_map.go 73.15% <0.00%> (-1.03%) ⬇️
server.go 83.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b765288...4c25cea. Read the comment docs.

@marten-seemann marten-seemann merged commit 6ff34f0 into master Oct 30, 2020
@marten-seemann marten-seemann deleted the fix-server-close-deadlock branch October 30, 2020 08:27
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A possible deadlock: conflicting lock order between packetHandlerMap and baseServer
2 participants