Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close session on errors unpacking errors other than decryption errors #2756

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 7, 2020

Fixes #2755.
Needs to be merged after #2757.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #2756 into master will increase coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2756      +/-   ##
==========================================
+ Coverage   86.62%   86.63%   +0.01%     
==========================================
  Files         128      128              
  Lines        9963     9979      +16     
==========================================
+ Hits         8630     8645      +15     
- Misses       1005     1007       +2     
+ Partials      328      327       -1     
Impacted Files Coverage Δ
packet_unpacker.go 86.11% <70.00%> (+0.11%) ⬆️
session.go 77.53% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0f0a8...a528c4c. Read the comment docs.

@marten-seemann marten-seemann merged commit 8c348c2 into master Sep 10, 2020
@marten-seemann marten-seemann deleted the handle-aead-errors branch September 10, 2020 03:25
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AEAD errors are ignored by the session
2 participants